Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tests and build to net7 except for Fable (net6) #525

Merged
merged 9 commits into from
Nov 27, 2022
Merged

Conversation

wallymathieu
Copy link
Member

@wallymathieu wallymathieu commented Nov 26, 2022

Co-authored-by: @rodriguestiago0

 Co-authored-by: Tiago Rodrigues <[email protected]>
@wallymathieu wallymathieu changed the title Upgrade to net7 Upgrade build to net7, add netstandard2.1 to FSharpPlus Nov 26, 2022
@wallymathieu wallymathieu changed the title Upgrade build to net7, add netstandard2.1 to FSharpPlus Upgrade build to net7 Nov 26, 2022
Copy link
Member

@abelbraaksma abelbraaksma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some warnings, where they here before? See Files tab. For instance:

Possible incorrect indentation: this token is offside of context started at position (234:1). Try indenting this token further or using standard formatting conventions.

<DefineConstants Condition=" '$(Configuration)' == 'Fable3'">$(DefineConstants);FABLE_COMPILER;FABLE_COMPILER_3;FABLE_COMPILER_FAKE</DefineConstants>
<TargetFramework>net6.0</TargetFramework>
</PropertyGroup>
<PropertyGroup>
Copy link
Member

@abelbraaksma abelbraaksma Nov 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the 8 space indent? I think 2 or 4 are common (spaces, not tabs). Probably best to have formatting changes in a separate PR and doing it across the board, though in this case, I think the default of 2 spaces was fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be when Visual Studio does changes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it was spaces but has been changed to tabs.

Copy link
Member

@abelbraaksma abelbraaksma Nov 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wallymathieu VS will honor the .editorconfig settings. However, maybe this project does not have specific settings for fsproj files. In which case it will use whatever default your system has.

Here's a snippet for .editorconfig, maybe try that and re-edit & save in your editor, see what happens?

# Project files and app specific XML files
[*.{csproj,fsproj,shproj,projitems,props,targets,xaml}]
trim_trailing_whitespace = true
insert_final_newline     = true
indent_style             = space
indent_size              = 2
charset                  = utf-8

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. We should have that setting in editorconfig. Looks like we have not added it yet for this repository. Perhaps something you want to make a PR for?

@abelbraaksma
Copy link
Member

abelbraaksma commented Nov 26, 2022

Btw, just curious, but looking at the changes, this doesn’t create a mandatory dep on net7 for the libs, right? I mean, I’d assume for the time being that ‘lowest denominator’ for nuget packages will be the rule, unless that’s no longer possible.

@wallymathieu
Copy link
Member Author

Notice that the library still has netstandard as the target framework. The build runs on net7 though.

@wallymathieu wallymathieu changed the title Upgrade build to net7 Upgrade tests and build to net7 except for Fable (net6) Nov 26, 2022
@abelbraaksma
Copy link
Member

got it ☝️ , thanks.

@wallymathieu wallymathieu merged commit 80616e3 into master Nov 27, 2022
wallymathieu added a commit that referenced this pull request Dec 2, 2022
This reverts commit 80616e3.
The reason being that we ended up encountering F# issue dotnet/fsharp#14313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants